-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change theano imports to aesara #83
Conversation
I changed the imports from
Looks like there are a few that happened in different tests. How should we go about fixing some of these? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a tricky situation, because the PyMC3 (version 3) dependency will always entail the use of Theano-PyMC, but we want to preempt the transition to Aesara that's coming with version 4.
Right now, all we can do is remove the explicit theano
and aesara
dependencies in setup.py
and allow the pymc3
dependency to determine which one is used. For this to work, we need to change statements like import theano
to
try:
import theano as aesara
except ImportError:
import aesara
To test that this works, we need to run the test suite with a standard PyMC3 release that uses Theano-PyMC (i.e. test the non-exception case) and also the current PyMC3 master
branch (i.e. the exception case), which is a version 3 branch that uses Aesara.
442b130
to
38ed07c
Compare
55c6496
to
a408df0
Compare
f633421
to
d40f9d2
Compare
Thank you for opening a PR!
Here are a few important guidelines and requirements to check before your PR can be merged:
Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.
If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.